The following document contains the results of FindBugs
FindBugs Version is 2.0.3
Threshold is medium
Effort is min
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in org.waarp.gateway.ftp.LogExport.setDestinationWriter(): new java.io.FileWriter(String) | I18N | DM_DEFAULT_ENCODING | 133 | High |
Found reliance on default encoding in org.waarp.gateway.ftp.LogExport.setDestinationWriter(): new java.io.OutputStreamWriter(OutputStream) | I18N | DM_DEFAULT_ENCODING | 130 | High |
org.waarp.gateway.ftp.LogExport.start devrait être package protected | MALICIOUS_CODE | MS_PKGPROTECT | Not available | Medium |
org.waarp.gateway.ftp.LogExport.stop devrait être package protected | MALICIOUS_CODE | MS_PKGPROTECT | Not available | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.waarp.gateway.ftp.adminssl.HttpSslInitializer.waarpSecureKeyStore n'est pas final et n'est pas protégé face à du code malveillant | MALICIOUS_CODE | MS_CANNOT_BE_FINAL | Not available | Medium |
org.waarp.gateway.ftp.adminssl.HttpSslInitializer.waarpSslContextFactory n'est pas final et n'est pas protégé face à du code malveillant | MALICIOUS_CODE | MS_CANNOT_BE_FINAL | Not available | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Synchronization performed on java.util.concurrent.atomic.AtomicInteger in org.waarp.gateway.ftp.config.CircularIntValue.getNext() | MT_CORRECTNESS | JLM_JSR166_UTILCONCURRENT_MONITORENTER | 61 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
La méthode org.waarp.gateway.ftp.config.FileBasedConfiguration.setSERVERKEY(byte[]) risque d'exposer sa représentation interne en stockant un objet externe modifiable dans org.waarp.gateway.ftp.config.FileBasedConfiguration.SERVERADMINKEY | MALICIOUS_CODE | EI_EXPOSE_REP2 | 1424 | Medium |
org.waarp.gateway.ftp.config.FileBasedConfiguration.fileBasedConfiguration n'est pas final et n'est pas protégé face à du code malveillant | MALICIOUS_CODE | MS_CANNOT_BE_FINAL | Not available | Medium |
Exceptional return value of java.io.File.mkdirs() ignored in org.waarp.gateway.ftp.config.FileBasedConfiguration.initializeAuthent(String, boolean) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 1494 | Medium |
Ecriture d'un champ statique org.waarp.gateway.ftp.config.FileBasedConfiguration.configuration depuis la méthode d'une instance org.waarp.gateway.ftp.config.FileBasedConfiguration.setConfigurationServerFromXml(String) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 1301 | Medium |
Ecriture d'un champ statique org.waarp.gateway.ftp.config.FileBasedConfiguration.hashConfig depuis la méthode d'une instance org.waarp.gateway.ftp.config.FileBasedConfiguration.setConfigurationServerFromXml(String) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 1302 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.waarp.gateway.ftp.database.DbConstant.gatewayAdmin n'est pas final et n'est pas protégé face à du code malveillant | MALICIOUS_CODE | MS_CANNOT_BE_FINAL | Not available | Medium |
The class name org.waarp.gateway.ftp.database.DbConstant shadows the simple name of the superclass org.waarp.common.database.DbConstant | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 28 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in org.waarp.gateway.ftp.database.data.DbTransferLog.saveDbTransferLogFile(DbPreparedStatement, String): new java.io.FileWriter(String) | I18N | DM_DEFAULT_ENCODING | 1095 | High |
La méthode org.waarp.gateway.ftp.database.data.DbTransferLog.getStart() risque d'exposer sa représentation interne en renvoyant org.waarp.gateway.ftp.database.data.DbTransferLog.start | MALICIOUS_CODE | EI_EXPOSE_REP | 967 | Medium |
La méthode org.waarp.gateway.ftp.database.data.DbTransferLog.getStop() risque d'exposer sa représentation interne en renvoyant org.waarp.gateway.ftp.database.data.DbTransferLog.stop | MALICIOUS_CODE | EI_EXPOSE_REP | 974 | Medium |
La méthode org.waarp.gateway.ftp.database.data.DbTransferLog.setStop(Timestamp) risque d'exposer sa représentation interne en stockant un objet externe modifiable dans org.waarp.gateway.ftp.database.data.DbTransferLog.stop | MALICIOUS_CODE | EI_EXPOSE_REP2 | 925 | Medium |
org.waarp.gateway.ftp.database.data.DbTransferLog.indexes est un tableau modifiable | MALICIOUS_CODE | MS_MUTABLE_ARRAY | 90 | High |
org.waarp.gateway.ftp.database.data.DbTransferLog.dbTypes est un tableau modifiable | MALICIOUS_CODE | MS_MUTABLE_ARRAY | 79 | Medium |
account isn't initialized in org.waarp.gateway.ftp.database.data.DbTransferLog.initObject() when invoked from constructor for superclass | CORRECTNESS | UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR | 117 | Medium |
filename isn't initialized in org.waarp.gateway.ftp.database.data.DbTransferLog.initObject() when invoked from constructor for superclass | CORRECTNESS | UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR | 117 | Medium |
hostid isn't initialized in org.waarp.gateway.ftp.database.data.DbTransferLog.initObject() when invoked from constructor for superclass | CORRECTNESS | UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR | 117 | Medium |
infotransf isn't initialized in org.waarp.gateway.ftp.database.data.DbTransferLog.initObject() when invoked from constructor for superclass | CORRECTNESS | UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR | 117 | Medium |
mode isn't initialized in org.waarp.gateway.ftp.database.data.DbTransferLog.initObject() when invoked from constructor for superclass | CORRECTNESS | UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR | 117 | Medium |
specialId isn't initialized in org.waarp.gateway.ftp.database.data.DbTransferLog.initObject() when invoked from constructor for superclass | CORRECTNESS | UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR | 117 | Medium |
start isn't initialized in org.waarp.gateway.ftp.database.data.DbTransferLog.initObject() when invoked from constructor for superclass | CORRECTNESS | UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR | 117 | Medium |
updatedInfo isn't initialized in org.waarp.gateway.ftp.database.data.DbTransferLog.initObject() when invoked from constructor for superclass | CORRECTNESS | UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR | 117 | Medium |
user isn't initialized in org.waarp.gateway.ftp.database.data.DbTransferLog.initObject() when invoked from constructor for superclass | CORRECTNESS | UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR | 117 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The class name org.waarp.gateway.ftp.database.model.DbModelFactory shadows the simple name of the superclass org.waarp.common.database.model.DbModelFactory | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 31-66 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The class name org.waarp.gateway.ftp.database.model.DbModelH2 shadows the simple name of the superclass org.waarp.common.database.model.DbModelH2 | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 48-192 | High |
La méthode org.waarp.gateway.ftp.database.model.DbModelH2.createTables(DbSession) concatène des chaînes au moyen de + en boucle | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 62 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The class name org.waarp.gateway.ftp.database.model.DbModelMysql shadows the simple name of the superclass org.waarp.common.database.model.DbModelMysql | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 49-224 | High |
La méthode org.waarp.gateway.ftp.database.model.DbModelMysql.createTables(DbSession) concatène des chaînes au moyen de + en boucle | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 66 | Medium |
La méthode org.waarp.gateway.ftp.database.model.DbModelMysql.nextSequence(DbSession) ne libère pas un verrou dans tous les chemins d'exception | MT_CORRECTNESS | UL_UNRELEASED_LOCK_EXCEPTION_PATH | 168 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The class name org.waarp.gateway.ftp.database.model.DbModelOracle shadows the simple name of the superclass org.waarp.common.database.model.DbModelOracle | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 48-181 | High |
La méthode org.waarp.gateway.ftp.database.model.DbModelOracle.createTables(DbSession) concatène des chaînes au moyen de + en boucle | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 64 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The class name org.waarp.gateway.ftp.database.model.DbModelPostgresql shadows the simple name of the superclass org.waarp.common.database.model.DbModelPostgresql | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 44-175 | High |
La méthode org.waarp.gateway.ftp.database.model.DbModelPostgresql.createTables(DbSession) concatène des chaînes au moyen de + en boucle | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 59 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
La méthode org.waarp.gateway.ftp.file.SimpleAuth.getAccounts() risque d'exposer sa représentation interne en renvoyant org.waarp.gateway.ftp.file.SimpleAuth.accounts | MALICIOUS_CODE | EI_EXPOSE_REP | 182 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.waarp.gateway.ftp.snmp.FtpCounter32 doesn't override org.snmp4j.smi.Counter32.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 52 | Medium |
type isn't initialized in org.waarp.gateway.ftp.snmp.FtpCounter32.setInternalValue() when invoked from constructor for superclass | CORRECTNESS | UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR | 45 | High |
entry isn't initialized in org.waarp.gateway.ftp.snmp.FtpCounter32.setInternalValue() when invoked from constructor for superclass | CORRECTNESS | UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR | 45 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.waarp.gateway.ftp.snmp.FtpGauge32 doesn't override org.snmp4j.smi.UnsignedInteger32.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 116-119 | Medium |
type isn't initialized in org.waarp.gateway.ftp.snmp.FtpGauge32.setInternalValue() when invoked from constructor for superclass | CORRECTNESS | UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR | 45 | High |
entry isn't initialized in org.waarp.gateway.ftp.snmp.FtpGauge32.setInternalValue() when invoked from constructor for superclass | CORRECTNESS | UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR | 45 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.waarp.gateway.ftp.snmp.FtpPrivateMib.WaarpDefinition devrait être à la fois final et package protected | MALICIOUS_CODE | MS_FINAL_PKGPROTECT | 590 | Medium |
org.waarp.gateway.ftp.snmp.FtpPrivateMib.WaarpDetailedValues devrait être à la fois final et package protected | MALICIOUS_CODE | MS_FINAL_PKGPROTECT | 783 | Medium |
org.waarp.gateway.ftp.snmp.FtpPrivateMib.WaarpErrorValues devrait être à la fois final et package protected | MALICIOUS_CODE | MS_FINAL_PKGPROTECT | 908 | Medium |
org.waarp.gateway.ftp.snmp.FtpPrivateMib.WaarpGlobalValues devrait être à la fois final et package protected | MALICIOUS_CODE | MS_FINAL_PKGPROTECT | 652 | Medium |
Le nom du champ org.waarp.gateway.ftp.snmp.FtpPrivateMib.WaarpDefinition ne commence pas par une minuscule | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available | Medium |
Le nom du champ org.waarp.gateway.ftp.snmp.FtpPrivateMib.WaarpDetailedValues ne commence pas par une minuscule | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available | Medium |
Le nom du champ org.waarp.gateway.ftp.snmp.FtpPrivateMib.WaarpErrorValues ne commence pas par une minuscule | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available | Medium |
Le nom du champ org.waarp.gateway.ftp.snmp.FtpPrivateMib.WaarpGlobalValues ne commence pas par une minuscule | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.waarp.gateway.ftp.snmp.FtpTimeTicks doesn't override org.snmp4j.smi.UnsignedInteger32.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 116-119 | Medium |
type isn't initialized in org.waarp.gateway.ftp.snmp.FtpTimeTicks.setInternalValue() when invoked from constructor for superclass | CORRECTNESS | UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR | 45 | High |
entry isn't initialized in org.waarp.gateway.ftp.snmp.FtpTimeTicks.setInternalValue() when invoked from constructor for superclass | CORRECTNESS | UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR | 45 | Medium |